Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change background color of code area in dark theme #634

Closed
wants to merge 7 commits into from

Conversation

b-Istiak-s
Copy link
Contributor

@b-Istiak-s b-Istiak-s commented Aug 17, 2021

It's useless without this.

I am making the PR without testing. I know which color I chose. And, I may not test it cause, I am not going to use Debian for few days. :(

Code area (pre tag) and, user-card-meta's background

Make sure that you are going to commit to develop CoDesign's PR before merging it.

@ArtOfCode-
Copy link
Member

Seems like this should be part of the existing Co-Design PR?

@b-Istiak-s
Copy link
Contributor Author

b-Istiak-s commented Aug 21, 2021

Seems like this should be part of the existing Co-Design PR?

I have made changes to 3 pages. So, I am including all of them one by one.

https://github.com/Istiakshovon/qpixel/blob/6ed0026acd3cbbc65725dde6ad2698c198c5ef91/app/assets/stylesheets/application.scss#L212-L220
I had made changes to it in typography. https://github.com/codidact/co-design/blob/46e7b4c3e1db101d8b91d080cd0a58b1d7b97def/src/common/_typography.scss#L114-L122

But, you had also coded in application.scss that's why I had to make changes to the page also. Otherwise, it might affect design. Since, application is saying to make #f0f0f0 forever. I know one will be ignored and, another will work. But, as far as I can tell that is CoDesign will be ignored that's why I made changes to it either.

I had made changes for body b-Istiak-s@1ee83f6#diff-0869e3045a3b5ca0e44ed193977d1568d686ca2373f4b93a8a868e4099fc932dR19-R22
Unfortunately, I forgot to write body. But, it's available in CoDesign that's why I had deleted it again. https://github.com/codidact/co-design/blob/db4527d664bc90c340390703cdd066e7344ca3a1/src/common/_layout.scss#L67-L72 I had forgot to write color earlier that's why I committed there again.

Another one is user-meta-card,
Screenshot from 2021-08-21 16-33-37
According to inspect element, it is only available in application.scss if it is available in CoDesign than, I don't know cause, it wasn't available in my work place.

As far as I remember from my another PR, I have to make change to something else either which is user-list-user (only for hover). Here's the line. https://github.com/Istiakshovon/qpixel/blob/6ed0026acd3cbbc65725dde6ad2698c198c5ef91/app/assets/stylesheets/users.scss#L19

I think my words might unclear to you... 🤔

@b-Istiak-s b-Istiak-s closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants